rest-for-physics / rest-for-physics/framework
TRestDataSet does not read the date/time properly if time is not given.
Open
Nobody has claimed this yet.
good first issue
invalid
- Dominant language
- C++
- Stars
- 19
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
The startTime and endTime metadata members do not read properly the date if we do not provide full formatting.
E.g. if we use <parameter name="startTime" value="2023/01/01 00:00" /> it will work fine.
However, if we do <parameter name="startTime" value="2023/01/01" /> it will not work properly.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the C++ implementation of TRestDataSet for the startTime and endTime metadata members and the XML parameter parsing path. Reproduce the two parameter formats from the issue, then verify that a date-only value is interpreted correctly and that existing full date/time behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100