rest-for-physics / rest-for-physics/framework
The GEOM_SCALE identifier in TRestEveEventViewer.h causes wrong scale in visualization
@lobis is already working on this.
Since Feb 17, 2023.
- Dominant language
- C++
- Stars
- 19
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
Hi everyone,
I'm raising this issue because I recently had some problem with the EVE event viewer.
This issue is related with this thread.
In short: there is a scaling factor, GEOM_SCALE defined here source/framework/core/inc/TRestEveEventViewer.h, which is set to 0.1.
It scales the visualization of your geometry. One of the consequences is that the primary event coordinates appear to be "closer" to the geometry detector than it actually is. So for example, if you simulated some cosmic and then visualize with EVE, they will artificially appear as generated in the middle of your detector. Of course this is just about the visualization and does not affect the simulation process.
Some people already had this problem in the past, as here.
This scaling factor had already been modified in commits d2fdc6e5 (0.1 to 1) and 9f890664 (back to 1).
For the moment I manually modified theTRestEveEventViewer.h file to set GEOM_SCALE to 1 in my install. But this will probably mess with something else..
Should this parameter be modified? Following @lobis and @jgalan, this should be linked to Root versions and gdml files.
Root version: 6.26/10
Rest version: v2.3.15
commit c4db1698
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.