rest-for-physics / rest-for-physics/framework
Add a fix to solve few problems that may led to an invalid XML
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 19
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
There are other places where > needs to be used, for example inside the globalCut definition, inside TRestAnalysisPlot, the condition value can be something like >10. This could be solved by adding new optional fields greaterThan, lowerThan and equals.
This is done in a similar way inside TRestDataSet.
We also need to fix the command field inside TRestTask so that we can write plot.CombinedCanvas() instead of plot->CombinedCanvas().
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the globalCut definition, TRestAnalysisPlot condition values, and the command field in TRestTask; compare the existing TRestDataSet handling described in its documentation. Done means these cases produce valid XML and allow plot.CombinedCanvas() syntax instead of plot->CombinedCanvas().
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100