rest-for-physics / rest-for-physics/framework

Avoid code duplication for signal processing

Open
#353 14 comments 0 reactions 3 assignees View on GitHub

@juanangp is already working on this.

Since Dec 15, 2022.

development enhancement
Dominant language
C++
Stars
19
Forks
14
PR merge metrics
No merged PRs in 30d

Description

Some functions seems duplicated within TRestDetectorSignal and TRestRawSignal, for instance GetSignalSmoothed, GetBaseLine and GetBaseLineSigma.

I propose de following:

  • Implement generic methods for signal processing that should be agnostic of the original signal event.
  • Speed up data processing by extracting different parameters such as baseline, baselineSigma, threshold integral, risetime, maxPeak and so on using a single loop (funcion).
  • The new class or namespace for signal processing should lie inside framework since I believe it should be generic for different libraries (rawlib detectorlib and connectorslib)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.