rest-for-physics / rest-for-physics/framework
Ideas for enhancing TRestDataSet
@IAntolin is already working on this.
Since Mar 1, 2023.
- Dominant language
- C++
- Stars
- 19
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
Recently, TRestDataSet has been implemented at #345. Cool!
There are few enhancements that can still be interesting, or necessary!
-
The file selection using metadata rules might be really time consuming. We should have a
FileSelectionmethod that extracts metadata information from a metadata database that has been populated using the ROOT/REST official data repository. Using therestSQLtool. We could have simply an option to decide to use the "SQL" database insideTRestDataSet, or even better, create a new classTRestSQLDataSet::TRestDataSet(inheriting from TRestDataSet) that overloadsFileSelectionand defines the additional data members required to connect to the SQL database. -
Include cuts on events so that if one of the branches or columns could be used as discriminant to generate a final table of selected events.
-
#388
-
Add a method that allows to cut-off events that do not fulfil certain conditions, and at the same time should reduce the
fTotalDuration, it could be a method such asTRestDataSet::RemoveDataUnderConditions( std::string ). #443 -
Add unit tests / validation pipeline.
See also issue #13
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.