rest-for-physics / rest-for-physics/framework

Launch libraries pipelines

Open
#274 0 comments 0 reactions 0 assignees View on GitHub

@juanangp is already working on this.

Since Jun 29, 2022.

  • #259 by @juanangp — open
enhancement
Dominant language
C++
Stars
19
Forks
14
PR merge metrics
No merged PRs in 30d

Description

When we push to framework any changes, it might happen that something gets broken at a particular library pipeline. However, when changes are pushed or merged to master, the libraries pipelines are not validated. I have seen that the library launches the validation of the framework, but it does not happen the otherway around.

I believe the pipeline failing at rawlib: https://github.com/rest-for-physics/rawlib/pull/73 is because a change in the framework and not in the rawlib.

Would be easy that both, framework and libraries ask for validation?

I thought there might be a kind of recursivity problem because calling a validation file that calls again my validation.yml file, probably something nasty may happen.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review open pull request #259 and the framework's validation.yml, then compare it with the rawlib pull request #73. Determine how framework changes should request library pipeline validation without creating recursive validation calls. Done means both framework and library pipelines validate the relevant changes without recursion.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
ci-cd
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.