rest-for-physics / rest-for-physics/framework
CMake preprocessor definitions for libraries not working correctly
Open
@lobis is already working on this.
Since May 19, 2022.
bug
- Dominant language
- C++
- Stars
- 19
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
When a library is set to be compiled, a preprocessor definition is defined (see https://github.com/rest-for-physics/framework/blob/master/cmake/MacroRootDict.cmake#L523) to tell other libraries that the corresponding library exists.
For example if the detector library is found, REST_DetectorLib will be defined as a predecesor directive and this can be used in another library to add some code that would otherwise fail.
However the current implementation is not working correctly due to some bug, as pointed out by @KonradAltenmueller.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.