rest-for-physics / rest-for-physics/framework

Remove early return on `startup.cpp` when testing is enabled

Open
#169 7 comments 0 reactions 1 assignee View on GitHub

@nkx111 is already working on this.

Since Mar 28, 2022.

help wanted
Dominant language
C++
Stars
19
Forks
14
PR merge metrics
No merged PRs in 30d

Description

Originally startup.cpp caused problems with unit testing and to fix this we added an early return if testing was enabled:

#ifdef REST_TESTING_ENABLED
        return;
#endif

This doesn't seem to affect the running of tests, but makes the framework behave differently when testing is enabled, this means that users should not use the framework with tests compiled to produced results etc. and only use it to run the tests, then compile it again without tests. This is also true for the pipeline where in order to run tests the framework is compiled twice.

There should be a way to modify this file so that tests can be run and also the file keeps working as intended, so that we can avoid recompiling twice.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.