rest-for-physics / rest-for-physics/framework
REST standard pressure units
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 19
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
I am wondering if the standard units for pressure is atm or bar. They have slight difference. In TRestDetectorGas it stores pressure in atm, but in TRestSystemOfUnits the units with scale 1 is bar. Also in TRestSystemOfUnits the conversion to torr is wrong. 760 torr = 1 atm, not 1 bar
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the pressure handling in TRestDetectorGas with the unit definitions and torr conversion in TRestSystemOfUnits. Verify which standard the framework should use, then update the inconsistent pressure scale and conversion so that 760 torr corresponds to 1 atm, with the related unit behavior consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100