rest-for-physics / rest-for-physics/detectorlib
Time in Hits events produced with TRestDetectorSignalToHitsProcess
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 2
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
I've seen that all four methods to produce Hits from Signal in TRestDetectorSignalToHitsProcess (https://github.com/rest-for-physics/detectorlib/blob/master/src/TRestDetectorSignalToHitsProcess.cxx) have time component manually set to 0: fHitsEvent->AddHit(x, y, z, energy, 0, type);
I'm not sure if this has any purpose but would be useful to have again a time value related with the time bins of the original RawSignal.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/TRestDetectorSignalToHitsProcess.cxx and inspect the four methods that create Hits from Signal, including each fHitsEvent->AddHit call. Trace how the original RawSignal represents time bins and determine the intended mapping to each Hit's time field. Done means generated Hits preserve the relevant RawSignal timing instead of always using zero.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100