rest-for-physics / rest-for-physics/detectorlib
Drop support for old Garfield versions
- Dominant language
- C++
- Stars
- 2
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
Recently we started supporting new versions of Garfield, which come with breaking changes. I made a few changes to the CMake and the code via preprocessor directives to support both versions, but recently @DavidDiezIb had some problems with the old version which means there is probably some unnoticed issue. I don't think its worth it to keep supporting these old versions, so I vote to just be compatible with the most recent version or a fairly recent one. (I would say latest tag, but currently this latest tag has a bug...).
https://github.com/rest-for-physics/framework/pull/129/commits/e58bdf43282a40febc52c6454faa48eae37bb707 removes the cmake file used to find the old Garfield and I will make the appropriate changes in this PR.
What do you think? @jgalan @nkx111 @juanangp
Related PR: https://github.com/rest-for-physics/detectorlib/pull/41#pullrequestreview-920561221
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the CMake changes and preprocessor directives described in the issue, then review framework PR #129 and detectorlib PR #41 for the existing work. The change is done when old Garfield support and its finder configuration are removed and the detector library builds against the selected recent Garfield version without the old-version compatibility paths.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 20/100