rest-for-physics / rest-for-physics/detectorlib
Units in TRestDetectorGas
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 2
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
I think we should make a same system of units for TRestDetectorGas. Now the diffusion units are cm^0.5 and the e-Field units are V/mm. Moreover the plotting methods receive input field in V/cm. This is very confusing. Maybe we can make all the distance field in unit mm, as in REST standard unit system.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating TRestDetectorGas and its plotting methods, then inventory the current diffusion, electric-field, and plotting units described in the issue. Clarify the intended REST standard unit system and define consistent distance units before changing behavior; done means the affected interfaces and plots use documented, consistent units and existing tests or examples still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100