Mutating job arguments can cause creation of extra retry jobs
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 9.5k
- Forks
- 1.7k
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 25
Description
If a job mutates its arguments, Resque::Failure.create hands along the mutated arguments for retrying rather than the arguments as serialized from Redis. This results in extra jobs being created.
See this issue on resque-retry for a demo and more discussion.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Resque::Failure.create and trace how failed job arguments are obtained for retrying, comparing them with the arguments serialized in Redis. Use the linked resque-retry discussion as a reproduction reference; done means retries use the serialized arguments and no extra jobs are created when a job mutates its arguments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100