resque / resque/resque-scheduler

Resque::Scheduler::Lock::Resilient ignores namespaces

Open
#239 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Ruby
Stars
1.7k
Forks
477
PR merge metrics
No merged PRs in 30d

Description

It seem's like Resque::Scheduler::Lock::Resilient ignores namespaces, set via Resque.redis.namespace. So resque_scheduler_master_lock is created in global namespace. So it's not possible to use multiple stages with the same redis database only seperated via namespaces.

I think key has to be extented with Resque.redis.namespace in Resque::Scheduler::Lock::Resilient.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at Resque::Scheduler::Lock::Resilient and inspect how resque_scheduler_master_lock is built relative to Resque.redis.namespace. Reproduce the issue with two namespaces sharing one Redis database, then verify that the lock keys remain isolated and existing lock behavior still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
redis, ruby
Domain
backend, databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.