resque / resque/resque-pool

Write log messages to Resque.logger

Open
#75 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
456
Forks
149
Avg merge
9d 7h
Merged PRs (30d)
3

Description

Instead of opening an entirely new log (and writing all the code to support it), just piggyback log messages to Resque.logger. This way, configuration and log output is all in one place. This change can allow a bunch of code to be removed (Resque::Pool::Logging as well as the WINCH signal).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Resque::Pool::Logging and the WINCH signal, then trace where the pool currently opens its separate log. Compare those paths with Resque.logger; done means pool messages use that logger and the separate logging implementation and WINCH handling are removed without losing the requested log output.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.