resque-pool 0.5.0 broke resque:work rake task
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 456
- Forks
- 149
- Avg merge
- 9d 7h
- Merged PRs (30d)
- 3
Description
Hey guys,
I'm not sure if that was intentional, but resque-pool 0.5.0 (specifically, this commit: 2f91e9114556cb75c73a7b05d3ebaebec7ae9304) changed the way shutdown? method works and now there is no way to run rake resque:work without resque pool - it just exits immediately upon exiting the main processing loop (since there are no parent pids registered by resque-pool).
Basically, this means that by simply including resque-pool in a Gemfile of a project one loses ability to use resque without executing the resque-pool command.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare commit 2f91e9114556cb75c73a7b05d3ebaebec7ae9304 with the current shutdown? behavior, then trace the resque:work rake task after its main processing loop exits. Reproduce the immediate exit with resque-pool included; done means resque:work can run without the resque-pool command while pool workers still shut down correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100