rescript-lang / rescript-lang/vim-rescript
node_modules are not located correctly
Open
Nobody has claimed this yet.
- Dominant language
- Vim Script
- Stars
- 164
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
For some reason finddir returns the full path on my system so getCwd() . finddir() causes the path to be /Users/user/path/to/project//Users/user/path/to/project/node_modules/.... I had to remove getCwd() calls from rescript#UpdateProjectEnv() and it all works. It's probably something about my setup but I cannot figure it out.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the implementation of rescript#UpdateProjectEnv and inspect how finddir() and getCwd() are combined. Reproduce the duplicated absolute path described in the issue and verify that the resulting node_modules path is correct without requiring users to remove getCwd() calls.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- vim
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100