rescript-lang / rescript-lang/rescript

Rewatch: reserved package names

Open
#8,176 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
OCaml
Stars
7.5k
Forks
485
Avg merge
1d 2h
Merged PRs (30d)
55

Description

Bsb has a validation for reserved package names (as specified in rescript.json): a package may not be named _.

This is also tested in tests/build_tests/xpkg.

I wonder if this should be taken over into Rewatch, and if there are any other package names that should be reserved.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the reserved package-name validation in Bsb with Rewatch, using rescript.json and the existing tests in tests/build_tests/xpkg as the starting points. Determine whether Rewatch should enforce the same rule and identify any additional reserved names; done means the intended validation scope is documented and covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
build-system
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.