rescript-lang / rescript-lang/rescript

Migration tool should only rewrite file if actual changes were made

Open
#8,152 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
OCaml
Stars
7.5k
Forks
485
Avg merge
1d 2h
Merged PRs (30d)
55

Description

The migration tool rewrites files with new formatting even if there was no actual migration change made in the file. I think it'd be better to not do that, and only process the file if there's an actual migration to be made.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the migration tool and its file-processing entry point, then reproduce the case where a file needs no migration but is reformatted. The work is done when files with no actual migration change are left untouched while files with migration changes are still processed.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.