rescript-lang / rescript-lang/rescript
Automatic migrations should not trigger for dependencies
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 7.5k
- Forks
- 485
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 55
Description
It seems that automatic migrations can trigger for dependencies. Case in point: @rescript/react uses the deprecated Js.Nullable.t. This triggers a warning about deprecation (and migration of that), but in a weird broken loc, and that obviously can't be applied since deps can't be rewritten/migrated.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the automatic migration warning with the @rescript/react dependency using its deprecated Js.Nullable.t usage, then trace the compiler's handling of migrations for dependency code. Done means dependency sources no longer trigger warnings or migration attempts, while migrations for project code still work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, ocaml
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100