rescript-lang / rescript-lang/rescript
Allow `$` in identifiers
Open
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 7.5k
- Forks
- 485
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 55
Description
In JS, an identifier may contain the $ sign.
When using signals, there is the convention to use it to distinguish reactive values like in
const count$ = signal(0);
In ReScript,
let count$ = signal(0)
gives the error
Not sure what to do with this character: "$".
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test path is named, so first locate the compiler entry point that parses identifiers and the related compiler tests. Check how the $ character is currently rejected, then verify that names such as count$ are accepted in ReScript and compile correctly to JavaScript.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, ocaml
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100