rescript-lang / rescript-lang/rescript

JSX preserve mode: hardcoded "JsxRuntime"

Open
#8,079 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
OCaml
Stars
7.5k
Forks
485
Avg merge
1d 2h
Merged PRs (30d)
55

Description

In js_dump.ml, the module name "JsxRuntime" is hardcoded. This may prevent JSX preserve mode from working correctly with runtimes other than React.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading js_dump.ml and locate where the module name "JsxRuntime" is hardcoded. Determine how JSX preserve mode selects its runtime and what behavior is expected for runtimes other than React; done means preserve mode no longer assumes that hardcoded name and the relevant compiler behavior is covered by tests, if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.