rescript-lang / rescript-lang/rescript
Js.Re.matches -> RegExp.Result.matches - Unexpected bug caused by migration to v12
Open
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 7.5k
- Forks
- 485
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 55
Description
The automated migration results in a different output, which was very difficult to trace in my case. I spent around 4 hours today (mostly because the issue wasn't reproducing locally)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked ReScript v12 playground reproduction and compare the output produced before and after automated migration. Trace the Js.Re to RegExp.Result.matches change and define a regression test that preserves the expected result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100