rescript-lang / rescript-lang/rescript

update message to say that BigInts are supported in @unboxed variants

Open
#7,964 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
OCaml
Stars
7.5k
Forks
485
Avg merge
1d 2h
Merged PRs (30d)
55

Description

right now:

@unboxed type t = A(int) | B(int)

gives

This untagged variant definition is invalid: At most one case can be a number type (int or float).

but should probably say:

This untagged variant definition is invalid: At most one case can be a number type (int, float or bigint).

as support was added recently

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Search the compiler diagnostic for the shown @unboxed error, update the number-type wording to include bigint, and run the relevant compiler tests to confirm the diagnostic now matches the requested message.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
compilers
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.