rescript-lang / rescript-lang/rescript

formatter won't keep multiline for exceptions

Open
#7,946 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

formatter
Dominant language
OCaml
Stars
7.5k
Forks
485
Avg merge
1d 2h
Merged PRs (30d)
55

Description

how to test:

  1. type type t = {name: string, msg: string} and run formatter
  2. notice still single line
  3. type
type t = {
  name: string,
  msg: string,
}

and run formattter
4. notice still four lines
5. type exception Foo({name: string,msg: string}) and run formatter
6. notice still single line
7. type

exception Foo({
  name: string,
  msg: string,
})

and run formatter
8. BUG: formatter forces it to single line

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the numbered examples with the formatter, comparing the single-line and multiline forms for records and exceptions. Trace the formatter code reached by these inputs; done means intentionally multiline records and exception payloads remain multiline instead of being forced to one line.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.