rescript-lang / rescript-lang/rescript

Compiler safeguards when defining a __proto__ field

Open
#7,343 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
OCaml
Stars
7.5k
Forks
485
Avg merge
1d 2h
Merged PRs (30d)
55

Description

https://rescript-lang.org/try?version=v11.1.4&module=esmodule&code=C4TwDgpgBMULxQN4H1lgE4HtidQLigGdh0BLAOwHMBfAKFoClCA6AG00oAoU0sd8oAIgBmmTIOoBKWkA

It would be nice for compiler to prevent records creation with the __proto__ field name, since it doesn't work in JavaScript.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the record definition from the linked ReScript playground and inspect the compiler path that generates JavaScript for a proto field. Determine whether compilation should reject the field or otherwise safeguard the generated output, then add coverage for the observed behavior and verify the compiler result.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, ocaml
Domain
compilers
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.