rescript-lang / rescript-lang/rescript
RFC: Revise `char` primitive
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 7.5k
- Forks
- 485
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 55
Description
State of char type
ReScript has the char primitive type, which is rarely used. (I was one of those who used char to handle ASCII keycodes)
https://rescript-lang.org/docs/manual/latest/primitive-types#char
Note: Char doesn't support Unicode or UTF-8 and is therefore not recommended.
The char doesn't support Unicode, but only supports UTF-16 codepoint.
let a = '👋'
compiles to
let a = 128075;
Its value is the same as '👋'.codePointAt(0) result in JavaScript, which means that in the value representation, char is equivalent to int (16-bit subset).
Then, why don't we use just int instead of char?
charliterals are automatically compiled to codepoints. This is much more efficient than string representation when dealing with the Unicode data table.charsupports range pattern (e.g.'a' .. 'z') in pattern matching. This is very useful when writing parsers.
However, a char literal is not really useful to represent a Unicode character because it doesn't cover the entire Unicode sequence. It only returns the first codepoint value and discards the rest of the character segment.
To avoid problems, we should limit the value range of char literal to the BMP(Basic Multilingual Plane, U+0000~U+FFFF).
Suggestion
I suggest some changes that would keep the useful parts of char but remove its confusion.
- Get rid of
chartype or make it an alias ofint - Keep char literal syntax, but with internal representation as regular integers
- Limit the char literal range to BMP in the syntax level.
- Support range patterns for regular integers
- Remove the
Charmodule.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked primitive-types#char documentation and review the current Char module and compiler handling of char literals and range patterns. Clarify the representation, BMP limits, integer range patterns, and whether Char is removed; done requires an agreed design and corresponding implementation and tests, none of which are named here.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, ocaml
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100