rescript-lang / rescript-lang/rescript-vscode

Wrong hover content when there is `include` above a value

Open
#968 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
ReScript
Stars
354
Forks
63
Avg merge
11h 29m
Merged PRs (30d)
1

Description

Working with RescriptCore I encountered this problem. When adding a new value, the hover content is wrong. It appears to take the contents of include Core__Global

image

image

If you move include Core__Global below assert_eq the content is correct

rescript-language-server -v
1.51.0-next-1d7dfb7.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the hover issue in RescriptCore using the reported rescript-language-server version, with include Core__Global above and below assert_eq. Start by comparing the hover content in both arrangements. Done means the hover content is correct regardless of the include position.

Written by the indexing model from the issue text.

Assessment

Tech stack
vscode
Domain
developer-experience, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.