rescript-lang / rescript-lang/rescript-vscode
Create interface command does not work on external React components
Open
Nobody has claimed this yet.
- Dominant language
- ReScript
- Stars
- 354
- Forks
- 63
- Avg merge
- 11h 29m
- Merged PRs (30d)
- 1
Description
The following .res file:
type props = {children: React.element}
@module("@mui/material/styles")
external make: React.component<props> = "StyledEngineProvider"
yields me the following interface
@react.component
external make: (~children: React.element) => React.element =
"StyledEngineProvider" "#rescript-external"
but it should be identical to the .res file, since it's only using external.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Create interface command and reproduce the behavior using the .res example in the issue. Compare the generated interface with the source external declaration; done means the command preserves the external declaration rather than adding the shown React component annotation and extra external string.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, vscode
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100