rescript-lang / rescript-lang/rescript-vscode

Code analysis gives warning when catching on exception from other module

Open
#716 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
ReScript
Stars
354
Forks
63
Avg merge
11h 29m
Merged PRs (30d)
1

Description

Consider the following example:

module Test = {
  exception Nested

  @raises(Nested)
  let raises = async () => raise(Nested)
}

let raises = async () =>
  try await Test.raises() catch {
  | Test.Nested => Js.log("Not found")
  }

it gives me:
raises might raise Nested (test.res:9:12) and is not annotated with @raises(Nested)

However, if I open Test instead:

module Test = {
  exception Nested

  @raises(Nested)
  let raises = async () => raise(Nested)
}

open Test

let raises = async () =>
  try await Test.raises() catch {
  | Nested => Js.log("Not found")
  }

Everything works fine

Issue transferred from (https://github.com/rescript-association/reanalyze/issues/188)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the warning with the qualified Test.Nested example in test.res, then compare it with the open Test variant. Trace the code-analysis path that resolves qualified exceptions; done means the qualified catch no longer produces the incorrect @raises warning while the existing open form remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
vscode
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.