rescript-lang / rescript-lang/rescript-vscode

Cannot apply renaming inside `%%private` blocks.

Open
#599 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
ReScript
Stars
354
Forks
63
Avg merge
11h 29m
Merged PRs (30d)
1

Description

Inside %%private(...) trying to rename a function's parameter, or even local variables, is not allowed.

image

I'm using the latest version of the extension: 1.8.1 (at the time of writing). It happens both in VSCode and Emacs (using lsp-rescript).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the rename failure for function parameters and local variables inside %%private(...) blocks in VSCode and Emacs using lsp-rescript. Start by tracing how the extension or language-server integration handles rename requests in that context; done means both reported rename cases work in the affected editors.

Written by the indexing model from the issue text.

Assessment

Tech stack
emacs, vscode
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.