rescript-lang / rescript-lang/rescript-vscode
Error in path handling if it contains '#' symbol
Nobody has claimed this yet.
- Dominant language
- ReScript
- Stars
- 354
- Forks
- 63
- Avg merge
- 11h 29m
- Merged PRs (30d)
- 1
Description
OS: Windows
I created a project with a path containing the '#' symbol. 😂
When the rescript watcher found a problem in a source code it shows the problem in the problems tab.
But the file location has the wrong file path. The tail has been cut and the location has pointed to the parent directory of a directory with the '#' symbol.
For example "C:/dev/#baddir/project/App.res" has cut to "C:/dev/". Also if to click on the "problem item" vscode will try to open the file and shows the error message in the vscode notification: "Unable to open 'dev': File is a directory."
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue on Windows with a project path such as C:/dev/#baddir/project/App.res, then follow the ReScript watcher output into the VS Code Problems tab. Check how the reported file location is represented when the path contains '#'; done means the full path is preserved and selecting the problem opens the source file rather than its parent directory.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- vscode
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100