rescript-lang / rescript-lang/rescript-vscode
Using "rename symbol" on labelled argument breaks
Open
Nobody has claimed this yet.
- Dominant language
- ReScript
- Stars
- 354
- Forks
- 63
- Avg merge
- 11h 29m
- Merged PRs (30d)
- 1
Description
When renaming a labelled arg, if you include the ~ it propogates to the renamed locations. If you remove it then it does not stay a labelled argument.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the labelled-argument rename behavior in the VS Code extension using the attached demonstration, testing both renaming with and without the ~. Trace the rename-symbol handling until the argument label is processed; done means the ~ is preserved correctly at every renamed location without depending on whether it was included in the selected symbol.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- vscode
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100