rescript-lang / rescript-lang/reanalyze
`npm run build406` fails
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 281
- Forks
- 22
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 7
Description
The command npm run build406 found in Contributing.md fails:
$ npm run build406
> reanalyze@2.25.1 build406
> cp src/dune src/dune.saved && cp src/dune.406 src/dune && npm run build && mv src/dune.saved src/dune || mv src/dune.saved src/dune
> reanalyze@2.25.1 build
> dune build
File "src/Compat.ml", line 104, characters 4-24:
Error: Unbound record field Format.mark_open_tag
Hint: Did you mean mark_open_stag?
Because it is "needed for ReScript projects", and "[t]his repository is only for keeping OCaml compatibility with an old version of reanalyze", the build406 command can probably be discarded, and all the code be made compatible with OCaml >= 4.08 only (as per reanalyze.opam) by removing a lot of cppo guarded code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing npm run build406 from Contributing.md and inspect the build scripts using src/dune and src/dune.406. Read the compatibility code around src/Compat.ml line 104 and compare the OCaml requirement in reanalyze.opam. Done means the supported build path is consistent with the documented compatibility policy and the failing command or obsolete guarded code has a clear resolution.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- build-system, compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100