Navigating away after editing Page Properties doesn't save nor warn.
Open
@NGPixel is already working on this.
Since Aug 13, 2019.
Assessment
This issue has not been assessed yet.
Description
enhancement
Describe the bug
If you edit a page, the page editor will normally warn you if there are unsaved changes. However, the warning doesn't occur if you've only changed Page Properties, nor are the Page Properties saved.
To Reproduce
Steps to reproduce the behavior:
- Edit a Page
- Click on "Page" link at top to enter the "Page Properties" screen
- Change Title and/or Short Description (no other fields were tested, since they are greyed out in 2.0.0-beta.241)
- Click "OK"
- Click "Close" (there will be no warning; the changes will only save if you click "Save" before "Close")
Expected behavior
Either:
- Clicking "OK" on Page Properties should save the properties (and not do a full save).
- Or, the Close button and other means of navigating away should trigger the warning of unsaved changes and confirmation to discard (to match the behavior that occurs if you change the page's content).
Screenshots
If applicable, add screenshots to help explain your problem.
Host Info:
- OS: unknown
- Wiki.js version: 2.0.0-beta.241
- Database engine: SQLite
Additional context
Add any other context about the problem here.
- Dominant language
- Vue
- Stars
- 28.9k
- Forks
- 3.3k
- Avg merge
- 5d 20h
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.