requarks / requarks/wiki

Git backend storage give-up on sync

Open
#2,082 7 comments 3 reactions 1 assignee View on GitHub

@NGPixel is already working on this.

Since Jun 18, 2020.

bug contrib-easy
Dominant language
Vue
Stars
28.9k
Forks
3.3k
Avg merge
5d 20h
Merged PRs (30d)
1

Description

Describe the bug
When Git backend storage fail for some reason (git server restarting for exemple), the storage function fail (obviously). But when the git service is back up, WikiJS never try to save again. It stay in error mode.

To Reproduce
Steps to reproduce the behavior:

  • Enable Git as storage backend
    • Configure it so that it work
  • Make your Git server unavailable
  • Wait until WikiJS tries to save new pages to it
  • You will get an expected error of the type (this is the error in my case) in the status windows of the backend
remote: Bad Gateway fatal: unable to access 'https://git.mydomain.fr/wiki_data.git/':
  The requested URL returned error: 502 error: Could not fetch origin 
  • Put the Git server back online
  • WikiJS never try to sync again

Additional steps :

  • Click on Force Sync
    • It sync but don't autosync again

Expected behavior

WikiJS should always try to sync even if the previous sync failed (maybe with a cooldown)

Screenshots
N/A

Host Info (please complete the following information):

  • OS: Docker
  • Wiki.js version: 2.4.105
  • Database engine: MariaDB - 10.5.3

Additional context
Add any other context about the problem here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.