replicatedhq / replicatedhq/kots

'kots pull' doesn't preserve valuePlaintext

Open
#508 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type::bug
Dominant language
Go
Stars
950
Forks
98
Avg merge
1d 36m
Merged PRs (30d)
31

Description

The admin console workflow to update files says to

  • kots download
  • make changes
  • kots upload
Screen Shot 2020-05-07 at 11 43 39 AM

However it's not clear where to make changes.

  • If I make them in base, then do kots upload, those are reflected in the diff and applied. However if I then make config changes in the console, my changes get overwritten.
  • If I make them in upstream, then do kots upload, the changes don't appear in the diff until I also make some sort of config change in the console.

The best solution I found was to do kots download --decrypt-password-values, make changes in upstream, and run kots pull <slug> --local-path <slug>/upstream --rootdir newdir --exclude-admin-console --license-file <slug>/upstream/userdata/license.yaml --downstream this-cluster. I could then upload newdir/<slug> (or say --rootdir . and update in-place) but the password values from config that show up in base have been changed in a way I don't trust.

That kots pull invocation isn't easy to figure out, and it doesn't appear to treat valuePlaintext correctly.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the kots pull command and how it handles valuePlaintext during the reported download, edit, and upload workflow. Reproduce the invocation with --decrypt-password-values, then verify that password values remain correctly preserved rather than being transformed unexpectedly.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.