replicatedhq / replicatedhq/kURL

When a proxy fails, the password should not be dumped to the screen

Open
#516 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
809
Forks
81
Avg merge
1d 21h
Merged PRs (30d)
20

Description

https://github.com/replicatedhq/kURL/blob/a18c2e2a488c5f28dc6504b84f38bf73f0c605a8/scripts/common/proxy.sh#L68

Ideally, HTTPS_PROXY=https://USERNAME:PASSWORD@10.0.0.1:8080/ would be redacted to not show the password.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading scripts/common/proxy.sh at the linked line and reproduce the proxy failure path. Check what is written to the screen when HTTPS_PROXY contains USERNAME:PASSWORD, then verify that the password is redacted while the useful proxy error remains visible.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.