render-engine / render-engine/render-engine

Adopt ExceptionGroups in Collection.render for one time Exception Reporting

Open
#1,250 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

discussion post-3.15
Dominant language
Python
Stars
61
Forks
40
Avg merge
4h 29m
Merged PRs (30d)
10

Description

ExceptionGroup / except* in Collection.rendercollection.py:314

This allows you to reporting every broken page in one build instead of one per rebuild.

ThreadPool.imap_unordered currently raises the first exception and silently drops the rest.

Three bad pages today = fix one, rebuild, discover the next, three times over. Collect per-entry failures and raise them together.

FMI:

[!NOTE]
This needs to be rebased into the remove-3.10-python-3.15-release branch that will be merged later into main

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Collection.render at collection.py:314 and trace how ThreadPool.imap_unordered handles worker exceptions. Review PEP 654 and the ExceptionGroup documentation, then verify that failures from multiple broken pages are collected and reported together in one build. The change should be based on the remove-3.10-python-3.15-release branch before it is merged into main.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
63/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.