remarkjs / remarkjs/react-markdown
Allow safeProtocol to be passed as a parameter for defaultUrlTransform
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 15.9k
- Forks
- 919
- PR merge metrics
- No merged PRs in 30d
Description
Initial checklist
- I read the support docs
- I read the contributing guide
- I agree to follow the code of conduct
- I searched issues and discussions and couldn’t find anything (or linked relevant results below)
Problem
Hello! I'd like to add tel to the allowed protocols but not deviate so much from defaultUrlTransform to write my own
Current solutions
Writing your own urlTransform. I don't prefer this since I'd like to follow the default even if changes in future versions.
Proposed solutions
I'd like to propose that the safeProtocol value used in defaultUrlTransform could be passed as a parameter
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the defaultUrlTransform entry point and the safeProtocol value it uses. Review the surrounding urlTransform behavior and existing tests, then confirm that safeProtocol can be supplied as a parameter so protocols such as tel can be allowed without replacing the default transform.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100