completion handler on hide

Open
#103 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
swift
Domain
mobile-dev

Research direction

Start by locating the existing if hide timer and the HUD hide flow described in issue #103. Add a completion callback that runs after the delayed hide finishes, and verify that it supports the requested sequence of showing success text, hiding the HUD, and then dismissing the view controller.

Written by the indexing model from the issue text.

Description

Great work, thanks for making it available! This thing is sweet.

One minor feature request. It would be nice to get a callback after the if hide timer, since I typically have to take some action on my end. For example, I want to show "Success!" for 1.5 seconds and then dismiss my modal vc. The builtin hiding delay is thoughtful but I can't take advantage of it without a completion handler.

Typical flow:

  1. show hud for at least one second even if network request is quite fast
  2. show "Success!" for 1.5 seconds to give user a chance to read
  3. hide hud & dismiss view controller
Dominant language
Swift
Stars
3k
Forks
506
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from relatedcode/ProgressHUD

All issues in relatedcode/ProgressHUD

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.