refined-github / refined-github/refined-github

Handle archived PRs

Open
#9,867 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

accepted enhancement small under discussion
Dominant language
TypeScript
Stars
32.2k
Forks
1.9k
Avg merge
2d 5h
Merged PRs (30d)
36

Description

There's a new state for PRs: archived.

Archived PRs are closed, locked and turned into a 404 for everyone except organization members.

Test URL

I don't know what "handling" them means for the whole extension. So far I have:

  • add isArchivedPR to github-url-detection
  • don't show locked-issue on archived PRs since it's redundant
  • include in the selectors for "PRs" in select-notifications

But there's definitely more issues and possible changes.

One thing to keep in mind is that if you see the PR you're not affected by its restrictions (you can comment, etc)

Screenshots

Image Image
Sidebar

Also note that there's no "lock this conversation", which we're probably using somewhere to detect "user is moderator" (but we might have already moved that check to the API, I don't remember)

Image
Notifications
Image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the archived PR at the test URL, then inspect the github-url-detection and select-notifications entry points and the locked-issue behavior. Identify all PR-specific handling affected by archived PRs; done means archived PRs are detected, excluded from redundant locked-issue UI, and included wherever PR notifications are selected.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, typescript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.