Possible richer ConnectResponse type in '@redux-devtools/extension'

Open
#1,097 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
api, devtools

Research direction

Start with ConnectResponse in packages/redux-devtools-extension/src/index.ts at lines 187-190, then compare it with the referenced type in extension/src/app/api/index.ts at lines 522-536. Determine whether the extension package type can be imported from or made compatible with the more precise definition. Done means the relationship between the two ConnectResponse shapes is resolved.

Written by the indexing model from the issue text.

Description

bug

Can ConnectResponse in '@redux-devtools/extension'

https://github.com/reduxjs/redux-devtools/blob/b82de745928211cd9b7daa7a61b197ad9e11ec36/packages/redux-devtools-extension/src/index.ts#L187-L190

be compatible with or imported from

https://github.com/reduxjs/redux-devtools/blob/b82de745928211cd9b7daa7a61b197ad9e11ec36/extension/src/app/api/index.ts#L522-L536

which seems more precise?

Dominant language
TypeScript
Stars
14.4k
Forks
1.2k
Avg merge
1d 6h
Merged PRs (30d)
20

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from reduxjs/redux-devtools

All issues in reduxjs/redux-devtools

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.