redpanda-data / redpanda-data/openmessaging-benchmark

Lack of instance_type setting should not cause critical failure

Open
#69 0 comments 0 reactions 1 assignee View on GitHub

@tmgstevens is already working on this.

Since Jun 29, 2023.

Dominant language
Java
Stars
40
Forks
32
No merged PRs in 30d

Description

This code introduces a regression where people using already existing hosts files receive a critical failure because instance_type is not set. Default values should have been added here as an option. (Blame: @tmgstevens )

line: "name: Redpanda{{ '+SASL' if sasl_enabled | default(False) | bool == True }}{{ '+TLS' if tls_enabled | default(False)|bool == True }}+{{ groups['redpanda'] | length }}x{{ instance_type }}"

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.