redpanda-data / redpanda-data/openmessaging-benchmark

Better error messages needed when only 1 client worker deployed

Open
#62 0 comments 0 reactions 1 assignee View on GitHub

@hcoyote is already working on this.

Since Sep 15, 2023.

Dominant language
Java
Stars
40
Forks
32
PR merge metrics
No merged PRs in 30d

Description

03:20:20.240 [main] INFO - Using DistributedWorkersEnsemble workers topology
Exception in thread "main" java.lang.IllegalArgumentException
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:128)
	at io.openmessaging.benchmark.worker.DistributedWorkersEnsemble.<init>(DistributedWorkersEnsemble.java:71)
	at io.openmessaging.benchmark.Benchmark.main(Benchmark.java:158)

DistributedWorkersEnsemble throws this arg error if there happens to be only one configured worker.

Swarm at least throws a useful error message telling you it requires more than 1 worker.

03:27:43.539 [main] INFO - Using SwarmWorker workers topology
Exception in thread "main" java.lang.IllegalArgumentException: Workers must be > 1
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
	at io.openmessaging.benchmark.worker.SwarmWorker.<init>(SwarmWorker.java:119)
	at io.openmessaging.benchmark.Benchmark.main(Benchmark.java:161)

TF should also probably throw an error if clients is less than 2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.