redpanda-data / redpanda-data/observability
Use $__rate_interval instead of hardcoded time interval values when using rate()
Nobody has claimed this yet.
- Dominant language
- Jsonnet
- Stars
- 52
- Forks
- 12
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 1
Description
Won't link internal thread, but we tend to use hardcoded intervals now for rates, when we should probably be using $__rate_interval
This starts to break down if the time span you're viewing is smaller than the selected interval.
A quick look shows we're hardcoding 1m/5m intervals in at least this dashboard
https://github.com/redpanda-data/observability/blob/main/grafana-dashboards/Redpanda-Ops-Dashboard.json
https://github.com/redpanda-data/observability/blob/main/grafana-dashboards/Connectors.json
https://github.com/redpanda-data/observability/blob/main/grafana-dashboards/Kafka-Consumer-Metrics.json
https://github.com/redpanda-data/observability/blob/main/grafana-dashboards/Kafka-Producer-Metrics.json
https://github.com/redpanda-data/observability/blob/main/grafana-dashboards/Kafka-Topic-Metrics.json
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by searching for rate() expressions and hardcoded 1m/5m intervals in Redpanda-Ops-Dashboard.json, Connectors.json, Kafka-Consumer-Metrics.json, Kafka-Producer-Metrics.json, and Kafka-Topic-Metrics.json. Update the relevant dashboard queries to use $__rate_interval, then confirm all affected dashboard definitions remain valid and no targeted hardcoded rate intervals remain.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- prometheus
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100