redpanda-data / redpanda-data/benthos

Linting lints less than run

Open
#187 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

cli needs more info
Dominant language
Go
Stars
571
Forks
120
Avg merge
2d 1h
Merged PRs (30d)
18

Description

Due to this code https://github.com/redpanda-data/benthos/blob/4d6fce617665d27d5599fc4a6b44769193d09cb9/internal/cli/common/run_flags.go#L198

we have cases, where calling lint works but run fails (with linting errors).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at internal/cli/common/run_flags.go around line 198 and compare how the lint and run commands determine which checks to apply. Reproduce the difference by running lint and run on the same configuration; done means both commands report the same linting errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.