hmset with object should not save NULL and `undefined` field value
Open
Nobody has claimed this yet.
feature
- Dominant language
- TypeScript
- Stars
- 17.6k
- Forks
- 2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 40
Description
We offen make an mistake that save null value to 'null' string and undefined value to 'undefined' string.
We have 2 choice:
- save empty '' string as the value
- don't save anything. (but this will also make a mistake when we want to remove a field value from an exist hash.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names HMSET with an object but no files, tests, or entry points. Start by locating the HMSET object-argument handling and its existing tests, then clarify whether null and undefined fields should be omitted or stored as empty strings before defining the completed behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nodejs, redis, typescript
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100