uncaught exception when command is aborted
Open
Nobody has claimed this yet.
Bug
- Dominant language
- TypeScript
- Stars
- 17.6k
- Forks
- 2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 40
Description
When a command is aborted with a signal its removed from the waitingToBeSent queue:
But then when a reply comes in, there's no handlers on the queue anymore so an error gets thrown.
Is there anything that can be done here to prevent this as there's no way to catch this error?
Environment:
- Node.js Version: 16
- Redis Server Version: 6.2
- Node Redis Version:
@redis/client @ 1.1.0 - Platform: macOS / Google Cloud Run
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in packages/client/lib/client/commands-queue.ts, especially the waitingToBeSent removal around lines 153-156 and reply handling around lines 117-119. Trace the aborted-command and subsequent-reply flow, then verify that an aborted command's late reply no longer causes an uncaught error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nodejs, redis, typescript
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100