SendCommand hGetall return format changed from v3 to v4
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 17.6k
- Forks
- 2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 40
Description
in v3, calling send_command with hGetall command would result in a return of format
{
"key1": "value1",
"key2": "value2",
}
in v4, sendCommand with "hGetAll" returns ["key1", "value1", "key2", "value2"]. This seems like a breaking change between the versions that wasn't listed
Seems like running client.HGETALL however returns in object format. Is there a method to coerce the sendCommand return to be formatted correctly?
Environment:
- Node.js Version: 16.13.2
- Redis Server Version: Redis 6.2.6
- Node Redis Version: 4.0.4
- Platform: MacOS 12.1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the sendCommand path for HGETALL and compare it with the client.HGETALL entry point named in the report. Check how v3 and v4 represent the command result and look for related tests or migration guidance. Done means the expected return behavior or supported coercion is established and covered by a regression test or clear documentation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nodejs, redis, typescript
- Domain
- backend, database
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100